Review of "Mission WS" version 0.3.1 (2)

Details Page Preview

Reorder GNOME workspaces by drag & drop, with Mac-Mission-Control-style hover circles on the overview thumbnails: a drag handle (top-left) to reorder and a close button (top-right) to remove a workspace.

Extension Homepage
https://github.com/Gerry3010/mission-ws

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
0.4.0 (3) Active
0.3.1 (2) Rejected
0.3.0 (1) Active

Previous Reviews on this Version

JustPerfection waiting for author
`appgrid.js` and `decorator.js` sharing the same code. What's the reason for that?
Gerald Hofbauer posted a review
Honestly, there's no good reason — thanks for catching it. When the extension started it only decorated the overview thumbnail strip; the app-grid tile support (appgrid.js) was bolted on later and I copy-pasted the strip decorator instead of sharing it, so the two files drifted into near-duplicates. I've now pulled all the shared lifecycle/hover-poll/drag/teardown logic into a single WorkspaceDecoratorBase (decoratorBase.js); decorator.js and appgrid.js are now thin subclasses that only override what genuinely differs (button size & placement, the app-grid state gating, and the drop-target signature). It'll be in the next submission.
Gerald Hofbauer auto- rejected
Auto-rejected because of new version 0.4.0 (3) was uploaded