Review of "ShadeShift" version 1

Details Page Preview

Manually assign separate wallpapers for Light and Dark styles with seamless transitions

Extension Homepage
https://github.com/anorak999/ShadeShift/issues

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:27
            this._lightEntry = new Gtk.Entry({
                hexpand: true,
                placeholder_text: _('Enter path or browse'),
                text: settings.get_string('light-wallpaper'),
            })
  • prefs.js:58
            this._darkEntry = new Gtk.Entry({
                hexpand: true,
                placeholder_text: _('Enter path or browse'),
                text: settings.get_string('dark-wallpaper'),
            })

All Versions

Version Status
1 Active

Previous Reviews on this Version

JustPerfection active
Approved but: 1. Please remove `original-author` and `license` from `metadata.json`. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions