Review of "WinAxis" version 1

Details Page Preview

Center active window (Ctrl+Alt+1) or resize to 80%x70% and center it (Ctrl+Alt+3)

Extension Homepage
https://github.com/HammadAhmed58343/WinAxis

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:55
                GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
                    this._doCenterWindow(window, resize);
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Timeout should be removed on disable and also before creating a new one (line 55 `extension.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions