Review of "namazvakti-gnome" version 1

Details Page Preview

Prayer Times and Next Prayer Countdown for GNOME Shell. Powered by the AlAdhan API.

Extension Homepage
https://github.com/alicontarli/namazvakti-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/cache.js:103
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:106
            this.menu.connect('open-state-changed', (menu, open) => {
                if (open) {
                    this.updateUI();
                }
            })

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

Ali Contarlı auto- rejected
Auto-rejected because of new version 2 was uploaded