Review of "Eridian Clock" version 1

Details Page Preview

Displays the eridian time from Project Hail Mary

Extension Homepage
https://github.com/DevInDistress/gnome-shell-extension-eridian-clock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • stylesheet.css
    placeholder stylesheet.css

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:40
            this._timeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 2366, () => {
                this._label.text = getEridianTime();
                return GLib.SOURCE_CONTINUE;
            })

All Versions

Version Status
1.3 (4) Active
1.3 (3) Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where is the git URL? Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
3_body_ auto- rejected
Auto-rejected because of new version 2 was uploaded