Review of "Smart Dock Menus" version 12

Details Page Preview

Adds smart quick-access menus to your dock icons. Right-click any supported app to instantly access what matters. Supported apps: — VS Code / VSCodium / Cursor: recent folders and workspaces — GitKraken: recently opened repositories — GNOME Files: recently opened files — Spotify: now playing, play/pause, next, previous — Text Editor: recently opened documents (txt, md, json, py, sh, and more) — Obsidian: recently opened vaults — GNOME Settings: Wi-Fi, Bluetooth, Sound, Displays, Power, and more Requires Dash-to-Dock or Ubuntu Dock.

Extension Homepage
https://github.com/Amgadezzat-andro/Rectent-Folders-Vscode-DashtoDock-Gnome-Extenstion

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
12 Active
11 Rejected
10 Active
9 Rejected
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What is the reason for `?.()` (line 560-561 `extension.js`)?
MEGOSTAR posted a review
open() is patched on the global PopupMenu prototype, so it runs for every menu in the shell, not just dock icons. Only dock icons have an app on sourceActor (.app, or ._app on older Dash-to-Dock), so I use optional chaining to check for it. If it's not a dock icon, appId ends up '' and nothing gets added. The get_id?.() is there because without the guards, opening any other menu would throw a TypeError.
JustPerfection active
JustPerfection posted a review
Approved but you should simply use `get_id()`