Review of "Tray Nest" version 1

Details Page Preview

AppIndicator, KStatusNotifierItem and legacy tray icon support for GNOME Shell — with icon grouping, per-indicator visibility/ordering/click overrides, per-indicator color and appearance customization, and a bundled icon picker. A friendly fork of gnome-shell-extension-appindicator.

Extension Homepage
https://github.com/mrzh4s/traynest

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • statusNotifierWatcher.js:352
    this._dbusImpl.run_dispose()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • tools/busAnalyzer.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • extension.js:38
            this._watchDogId = this._watchDog.connect('vanished',
                () => this._maybeEnableAfterNameAvailable())
  • extension.js:38
    this._watchDog.connect('vanished',
                () => this._maybeEnableAfterNameAvailable())

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

mrzh4s auto- rejected
Auto-rejected because of new version 2 was uploaded