Review of "Zeo Monitor Widget" version 2

Details Page Preview

Zeo-style desktop widgets for GNOME. Currently provides a floating monitering card.

Extension Homepage
https://github.com/mohitjoer/zeo-widgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:224
            this._detailLabel = new St.Label({
                text: '—',
                style_class: 'zeo-ring-detail',
                x_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:188
            this._drawingArea = new St.DrawingArea({
                width: RING_SIZE,
                height: RING_SIZE,
            })
  • extension.js:217
            this._nameLabel = new St.Label({
                text: label,
                style_class: 'zeo-ring-name',
                x_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:200
            this._pctLabel = new St.Label({
                text: '0%',
                style_class: 'zeo-ring-pct',
                x_align: Clutter.ActorAlign.CENTER,
                y_align: Clutter.ActorAlign.CENTER,
            })

All Versions

Version Status
6 Unreviewed
5 Rejected
4 Rejected
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

mohitjoer posted a review
now i have fixed it
JustPerfection active
Approved but please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions