Review of "QuickSettings Indicator Visibility Tool" version 7

Details Page Preview

A simple GNOME extension that allows you to control the visibility of indicators in quickSettings panel

Extension Homepage
https://github.com/VirlesFelyard/IndicatorVisibilityTool

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:8
    this._settings = this.getSettings('org.gnome.shell.extensions.IndicatorVisibilityTool')

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:9
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                if (!panel.statusArea.quickSettings._system)
                    return GLib.SOURCE_CONTINUE;
    			
    			this._signals = new Map();
                this._indicators = {
                    'system-mode':        panel.statusArea.quickSettings._system,
    

All Versions

Version Status
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active