Review of "Media Controls" version 1.2 (2)

Details Page Preview

Show the currently playing media in the top panel with playback controls and an iOS-inspired now-playing card. Works with any MPRIS-compatible player, including Spotify, Firefox, Chrome, VLC, mpv, Rhythmbox, and more.

Extension Homepage
https://github.com/naimur900/media-controller-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
2.1 (6) Inactive
2.1 (5) Active
2.0 (4) Active
1.3 (3) Inactive
1.2 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). 2. `this._destroyed` is a bad practice. Please remove that. 3. Remove version from the import (line 11 `artCache.js`). 4. You shouldn't create instances on global scope (line 81-83 `mpris.js`): [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions