Review of "Logi Battery Indicator" version 1

Details Page Preview

Shows battery percentage and charging status in the top bar for input devices such as the Logitech MX Master and MX Keys.

Extension Homepage
https://github.com/hornc-greedy/logi-battery

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Active
2 Rejected
1 Inactive

Previous Reviews on this Version

JustPerfection active
`this._destroyed` is a bad practice. Please remove that. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
hornc-greedy posted a review
Thanks for the feedback - I've removed the '_destroyed' flag and replaced it with a Gio.Cancellable that's created on enable and cancelled on disable, and passed into all async calls to abort in-flight operations cleanly. Updated version is pushed.
JustPerfection posted a review
Reviewed the next version. Feel free to ping me on GitHub (`jrahmatzadeh`) for the reviews or ask questions in GNOME Matrix channel.