Review of "Wadokei 和時計" version 2

Details Page Preview

Japanese temporal hours (不定時法): the current toki kanji in the top bar, computed from sunrise/sunset at your location. The popup lists all twelve hours. Optional hourly bell chime (off by default; strikes the traditional bell count at each hour's center). Language, time format, dawn/dusk offset, and location are configurable in preferences. No notifications.

Extension Homepage
https://github.com/tedvask/wadokei

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:302
    this._infoItem = new PopupMenu.PopupMenuItem('', {reactive: false})
  • extension.js:296
            this._label = new St.Label({
                text: '…',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:318
    this._locItem = new PopupMenu.PopupMenuItem('', {reactive: false})
  • extension.js:303
    this._rangeItem = new PopupMenu.PopupMenuItem('', {reactive: false})
  • extension.js:317
    this._sunItem = new PopupMenu.PopupMenuItem('', {reactive: false})
  • extension.js:313
    row

All Versions

Version Status
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages.
tianci posted a review
New upload addresses both reviews: signal connections now use connectObject()/disconnectObject() (review of v1), and schemas/gschemas.compiled is removed from the package (review of v2 — it was a stray development artifact, now also gitignored). The upload also includes the degree-based day boundary (official / civil / Edo 7°21′40″) added since v1, described in the repository README.
JustPerfection posted a review
Thanks!