GNOME Shell Extensions

Review of "Tiling Toggle" version 2

Details Page Preview

Tiling Toggle

by bennettone

Toggle-tile all windows on the current workspace with a single keybinding. Press again to restore.

Extension Homepage
https://github.com/villa1337/tiling-toggle
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
6 Unreviewed
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions