Review of "Colosseum" version 42

Details Page Preview

View live scores for your favorite sports teams.

Extension Homepage
https://github.com/sereneblue/gnome-shell-extension-colosseum

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-I-001 error

deprecated modules must not be imported

Deprecated module `Mainloop` is imported.

Do not use deprecated modules

  • extension.js:6
    Mainloop = imports.mainloop
  • extension.js:6
    imports.mainloop

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:81
    this._settings.connect('changed::' + CONSTANTS.PREF_POSITION_TOPBAR, this._updatePositionInPanel.bind(this))
  • extension.js:82
    this._settings.connect('changed::' + CONSTANTS.PREF_FOLLOWED_ONLY, this._update.bind(this))
  • extension.js:83
    this._settings.connect('changed::' + CONSTANTS.PREF_COMPACT_MODE, this._update.bind(this))

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • client.js:56
    this.session = new Soup.Session()

All Versions

Version Status
43 Rejected
42 Rejected
41 Active
40 Active
39 Active
38 Active
37 Rejected
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Rejected
28 Rejected
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please fix the shexli issues.