Review of "Keyboard Backlight Scheduler" version 0.5.3 (2)

Details Page Preview

Schedule keyboard backlight brightness with multiple time periods. Control your ASUS keyboard backlight automatically based on time of day.

Extension Homepage
https://github.com/cscortes/BacklightKeyboardGnomeExtension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 12 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:357
    console.log(`[KbdBacklight] v${ver} enabled`)
  • extension.js:375
    console.log(`[KbdBacklight] GSD Steps=${steps}, maxBrightness=${this._maxBrightness}`)
  • extension.js:416
    console.log(`[KbdBacklight] ASUS WMI LED (asus::kbd_backlight): ${asusLed}`)
  • extension.js:417
    console.log(`[KbdBacklight] ASUS platform (asus-nb-wmi): ${asusWmi}`)
  • extension.js:429
                console.log(`[KbdBacklight] Aura RGB: ${available} ` +
                    `(daemon=${detectAuraDaemon()}, asusctl=${detectAsusctlBinary()})`)
  • extension.js:454
    console.log(`[KbdBacklight] Set level ${clamped} (${pct}%) via GSD`)
  • extension.js:517
    console.log(`[KbdBacklight] Aura ${auraMode} #${hex} (${argv.join(' ')})`)
  • extension.js:379
    console.error(`[KbdBacklight] Could not read Steps from GSD: ${e.message}`)
  • extension.js:440
    console.error(`[KbdBacklight] read Brightness failed: ${e.message}`)
  • extension.js:456
    console.error(`[KbdBacklight] SetBrightness failed: ${e.message}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:152
            this.menu.connect('open-state-changed', (_m, open) => {
                if (open) this._refresh();
            })

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:591
    this._scheduleRows = this._scheduleRows.filter(r => r !== row)
  • prefs.js:601
    this._scheduleRows = this._scheduleRows.filter(r => r !== row)

All Versions

Version Status
0.5.5 (3) Unreviewed
0.5.3 (2) Active
1 Rejected

Previous Reviews on this Version

JustPerfection active
cscortes posted a review
I have fixed the warnings, and other issues. Where can I upload a newer version. I don't see an upload form here.
JustPerfection posted a review
You can upload the new version the same way you uploaded this version.