Review of "Software Hub" version 3

Details Page Preview

Software hub in quick settings

Extension Homepage
https://github.com/howbea/software-hub

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:68
            this._settings.connect(
                'changed::download-updates',
                () => {
                    this.checked =
                        this._settings.get_boolean('download-updates');
    
                    this._updateSubtitle();
                    this._updateMenuheader();
                }
            )

All Versions

Version Status
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active