GNOME Shell Extensions

Review of "Ultrawide Shortcuts" version 6

Details Page Preview

Ultrawide Shortcuts

by ding

Launch apps with a shortcut and snap windows into grid positions

Extension Homepage
https://github.com/lukewilde/ultrawide-shortcuts
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • compat.js:10 
    win.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:417 
          this._navGrabId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100,
        () => this._grabPendingNav())

All Versions

Version Status
7 Unreviewed
6 Rejected
5 Active
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

ding posted a review
Please ignore this version, I'm going to remove gnome 45 support and resubmit.
JustPerfection rejected