Review of "Liquid Glass" version 1

Details Page Preview

Applies a translucent, refractive 'liquid glass' effect (blur, tint, specular highlights and edge lighting) to the top panel, Quick Settings, notifications, OSDs and Dash to Dock, with adaptive text contrast and extensive customization.

Extension Homepage
https://github.com/ryohsuke1231/liquid-glass

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • dist/liquidEffect.js:218
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • dist/liquidEffect.js:224
    console.error(`[Liquid Glass] Failed to load shader: ${path}\n${e}`)
  • dist/liquidEffect.js:401
    console.error(`[Liquid Glass] Failed to build texture pool at pass ${i} (${pw}x${ph}): ${e}`)
  • dist/liquidEffect.js:568
    console.error(`[Liquid Glass] Failed to create crop texture (${w}x${h}): ${e}`)
  • dist/liquidEffect.js:648
    console.error(`[Liquid Glass] Pipeline initialization failed: ${e}`)
  • dist/liquidEffect.js:677
    console.error(`[Liquid Glass] Failed to build Gaussian pipelines: ${e}`)
  • dist/liquidEffect.js:723
    console.error(`[Liquid Glass] Crop pass failed; continuing with the padded texture: ${e}`)
  • dist/liquidEffect.js:738
    console.error(`[Liquid Glass] Failed to rebuild the texture pool: ${e}`)
  • dist/liquidEffect.js:852
    console.error(`[Liquid Glass] Failed to obtain the Cogl context: ${e}`)
  • dist/liquidEffect.js:236
    console.warn('[Liquid Glass] void main() not found; treating entire source as decl.')

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • dist/utils.js:96
    console.error(`[Liquid Glass] SelfExcludingSnapshotCapture: failed to connect to 'after-paint': ${e}`)
  • dist/utils.js:146
    console.error(`[Liquid Glass] SelfExcludingSnapshotCapture: paint_to_content failed: ${e}`)
  • dist/utils.js:262
    console.error(`[Liquid Glass][TextureBlitActor] failed to get Cogl context: ${e}`)
  • dist/utils.js:310
    console.error(`[Liquid Glass][TextureBlitActor] paint failed: ${e}`)
  • dist/utils.js:466
    console.error(`[Liquid Glass] SelfExcludingSnapshotActor: failed to connect to 'after-paint': ${e}`)
  • dist/utils.js:487
    console.error(`[Liquid Glass] Failed to create SelfExcludingSnapshotCapture actor: ${e}`)
  • dist/utils.js:623
    console.error(`[Liquid Glass] _insertCloneInZOrder failed: ${e}`)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:14
    this._settings = this.getSettings("org.gnome.shell.extensions.liquid-glass@thinkingcoding1231.gmail.com")

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Seems the code is generated by AI: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) Also, extension package shouldn't have ts files.