Review of "Stocks & Coins Enhanced" version 1.0 (1)

Details Page Preview

Displays stock and cryptocurrency quotes in the GNOME Shell panel with candlestick charts. A maintained fork of Stocks Extension by internetstaff and Florijan Hamzic. Market data is retrieved from third-party providers.

Extension Homepage
https://github.com/sanguri82-design/Stock-and-Coins-Enhanced

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • components/icon/icon.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:85
    this._mainEventHandler.connect('hide-panel', () => this.menu.close())
  • extension.js:88
    this.menu.connect('destroy', this._destroyExtension.bind(this))
  • extension.js:89
        this.menu.connect('open-state-changed', (menu, isOpen) => {
          this._mainEventHandler.emit('open-state-changed', { isOpen })
        })

All Versions

Version Status
1.0 (3) Unreviewed
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

SANGURI auto- rejected
Auto-rejected because of new version 1.0 (2) was uploaded