Review of "ShutterGuard" version 0.4.9 (2)

Details Page Preview

Keeps Canon EOS Live View active over USB. Requires the separate shutterguard-helper RPM. Supported targets: Fedora 43/44 and EPEL-enabled RHEL 9/10-compatible systems on x86_64 or aarch64. Install it before enabling ShutterGuard: sudo dnf install dnf-plugins-core && sudo dnf copr enable johnlsingleton/shutterguard && sudo dnf install shutterguard-helper

Extension Homepage
https://github.com/jsinglet/gnome-shell-extension-shutterguard

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
0.5.1 (3) Active
0.4.9 (2) Rejected
0.4.8 (1) Rejected

Previous Reviews on this Version

johnsingleton posted a review
GH Profile Here: https://github.com/jsinglet LinkedIn: https://www.linkedin.com/in/johnlsingleton/
JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). 2. `this._destroyed` is a bad practice. Please remove that. 3. Please cleanup all the properties on window close request in `prefs.js`. they won't allow the garbage collector to do its job after window close: [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects) 4. Please use empty lines between functions and classes. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions