Review of "Bifocals Window Placer" version 5.0 (5)

Details Page Preview

Simple window anchoring / resizing / moving / screen placement manager that works. Window size cycling between up to 3 percentage values based on the anchor point. All steps are optional and all values configurable. * Left / Right - maximizes window vertically and cycles through the percentage of the screen width. * Top / Bottom - keeps the window's horizontal position and width, and cycles through the percentage of the screen height. * Mid-screen - centres the window and cycles through the percentage of both screen axes. Move windows between screens / monitors. * Preserves the relative dimensions, so the window takes the same relative space and location as it did on the previous screen. * Does not get stuck when screens have different sizes or dimensions. Maximize * Toggles the window between maximized and its previous size. Restore * Restore a window to the size and position it had before the current run of Bifocals commands. * A window Bifocals has never touched falls back to the last saved restore point for any window of the same application. Every shortcut is rebindable, and clearing one disables that action.

Extension Homepage
https://github.com/shiznatix/bifocals-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5.0 (5) Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

shiznatix posted a review
JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 2. Please read [Extension Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html). Especially for `destroy` since the same bad practice is used here.
JustPerfection active
shiznatix posted a review
I have the fixes as per your original review in this commit: https://github.com/shiznatix/bifocals-gnome-extension/commit/a21f9dc9424dd92ca82a9d2945d7f0b0aaa4e6f7 But since this has been released already - should I apply the fixes into a new version or can I just re-upload a zip with the same version `5` and overwrite the current one?
JustPerfection posted a review
`version` is EGO's internal and auto increment. So, when you upload the new one, it will be version 6.