Review of "LAN/WAN IP Address" version 1

Details Page Preview

Show LAN (local) and WAN (external) IP address on the GNOME panel, with configurable display options.

Extension Homepage
https://github.com/volodyasilver/gnome-extension-lan-ip-address

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • LanIPAddressIndicator.js:41
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .eslintrc
    .eslintrc

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:14
    this._settings = this.getSettings()

All Versions

Version Status
1 Unreviewed