Review of "EnvyTweaks GPU Switcher" version 1

Details Page Preview

A GNOME Shell extension that provides an easy way to switch between GPU profiles on Nvidia Optimus systems in just a few clicks. Powered by envytweaks.

Extension Homepage
https://github.com/esfingex/envytweaks

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove: - `img/extension_screenshot-gnome-42-or-below.png` - `img/extension_screenshot-gnome-43-or-above.png` [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. You cannot use spawn command for reboot (line 73 `lib/Utility.js`). Use this instead: ```js import * as SystemActions from 'resource:///org/gnome/shell/misc/systemActions.js'; let systemActions = new SystemActions.getDefault(); systemActions.activateRestart(); ``` 3. `metadata.json` should only hold the standard `keys`. Please remove all unnecessary keys: [EGO Review Guidelines: unnecessary metadata keys](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
esfingex posted a review
Hi @JustPerfection, Thank you for the review! I have uploaded version 2 addressing all 3 points: 1. Removed PNG screenshot files from the extension repository and package. 2. Refactored requestReboot() to use SystemActions.getDefault().activateRestart() instead of spawning gnome-session-quit. 3. Cleaned non-standard metadata keys from metadata.json and bumped version to 2. Best regards!