Review of "OpenShift Alerts" version 4

Details Page Preview

Display OpenShift cluster alerts in the GNOME Shell panel

Extension Homepage
https://github.com/dcritch/gnome-openshift-alerts

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:86
    file.load_contents(null)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:156
            message.connect('accept-certificate', () => {
                return true;
            })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:22
            this._httpSession = new Soup.Session({
                timeout: 2
            })

All Versions

Version Status
7 Active
6 Rejected
5 Active
4 Rejected
3 Active
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please remove: - `clusters.yaml.example` - `gnome-openshift-alerts.png` - `install.sh` - `uninstall.sh`
dheighfid posted a review
New zip uploaded w/ unnecessary files removed. Thanks!