Review of "Browser Hub" version 1

Details Page Preview

Launch any browser, profile, or workspace from the GNOME top panel — Firefox, Chrome, Brave, Zen, and 50+ others, installed as a native package, Flatpak, or Snap. Also switch your default browser or start a private burner session, in one click. Not affiliated with any browser vendor.

Extension Homepage
https://github.com/baxyz/gnome-extensions

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:394
    		this._menuOpenStateId = menuSignals.connect("open-state-changed", (_menu, isOpen) => {
    			if (isOpen) {
    				clearDefaultBrowserCache();
    				this.redrawMenu();
    			}
    		})

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

baxyz posted a review
Ha, just saw a dead line code from Helpers4 lib. File vendor-helpers4.js, line 245: > new RegExp(`^#?([\\da-f]{3}|[\\da-f]{4}|[\\da-f]{6}|[\\da-f]{8})$`, "i"); Need to fix that in Helpers4 lib before update the build.
JustPerfection rejected
Didn't review since all files transpiled into one file. Please let them stay in the correct modules, just like the source. Also, don't hold anything in global scope after disable: - [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) - [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)