Review of "Special Workspace" version 2

Details Page Preview

Hyprland-style special workspace

Extension Homepage
https://github.com/sumitst05/special-workspace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `@sumitst05.com` from the schema id. The schema path is correct though. 2. Remove try-catch from enable.
JustPerfection posted a review
If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Sumit Tiwari posted a review
Hi JustPerfection, Thanks for the review and the community links! I have uploaded a new version the requested fixes: - Dropped @sumitst05.com suffix from the schema id in metadata.json and the XML file. - Removed the try-catch blocks from enable(). I actually went ahead and removed them from the rest of the codebase as well so that the errors can naturally bubble up to the system journal. I have also included a minor logic improvement in _getOrCreateSpecialWorkspace() to better handle edge cases (like when a user only has one active workspace). Thanks again for your time in reviewing this!