Review of "Quota Glance" version 1.0.1 (1)

Details Page Preview

View service quotas and balances from a GNOME panel.

Extension Homepage
https://github.com/geequlim/quota-glance

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • runtime/environment-loader.js:38
    GLib.file_get_contents(path)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • core/types.js
  • providers/http-dependencies.js
  • providers/preview.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:142
            indicator.connect('destroy', () => {
                if (this.#indicator === indicator) {
                    this.#indicator = null;
                    this.#indicatorHost = null;
                }
            })

All Versions

Version Status
1.0.1 (1) Unreviewed