Review of "TaskDock" version 1.0.1 (2)

Details Page Preview

A lightweight task list in the GNOME Shell top panel

Extension Homepage
https://github.com/joquers/TaskDock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:191
            this._clearCompletedButton = new St.Button({
                label: 'Clear completed',
                visible: false,
                can_focus: true,
                style_class: 'taskdock-link-button',
                accessible_name: 'Delete all completed tasks',
            })
  • extension.js:141
            this._entry = new St.Entry({
                hint_text: 'Add a task…',
                can_focus: true,
                x_expand: true,
                style_class: 'taskdock-entry',
                accessible_name: 'New task',
            })
  • extension.js:40
            this._panelCount = new St.Label({
                text: '',
                visible: false,
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'taskdock-panel-count',
            })
  • extension.js:182
            this._statusLabel = new St.Label({
                text: '',
                visible: false,
                x_expand: true,
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'taskdock-status',
            })
  • extension.js:129
            this._taskCountLabel = new St.Label({
                text: '0 tasks',
                y_align: Clutter.ActorAlign.CENTER,
                style_class: 'taskdock-task-count',
            })
  • extension.js:171
            this._taskList = new St.BoxLayout({
                vertical: true,
                style_class: 'taskdock-task-list',
            })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:414
            this._editDialog.connect('destroy', () => {
                this._editDialog = null;
            })

All Versions

Version Status
1.0.1 (2) Active
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection active
If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions