Review of "Dynamic Brightness" version 2

Details Page Preview

Adjusts your screen brightness to what's on screen: dimmer for bright pages, brighter for dark ones. Easier on the eyes when you switch between light and dark content. Features: • Brightness range right in Quick Settings • Customizable response curve • Smooth transitions • Pauses for fullscreen games and videos Light on resources: the screen is measured only when its content changes, from a tiny thumbnail rendered on the GPU. Notes: • Only the primary monitor is measured; multi-monitor support may come later. • GNOME 49 and later: works together with Automatic Screen Brightness. • GNOME 46–48: turn off Automatic Screen Brightness first, since both control the same setting. Bug reports and feature requests are welcome on GitHub.

Extension Homepage
https://github.com/mnural/dynamic-brightness-gnome

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:50
                this._sliderSignal = this._maxBrightnessSlider.connect('notify::value', (slider) => {
                    let rawVal = slider.value * 100;
                    let snappedVal = Math.round(rawVal / 10) * 10;
                    
                    // Prevent max brightness from dropping below 20%
           
  • extension.js:133
                this._toggleSignal = this.toggle.connect('notify::checked', () => {
                    this._indicator.visible = this.toggle.checked;
                })

All Versions

Version Status
10 Active
9 Active
8 Rejected
7 Rejected
6 Inactive
5 Inactive
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Nural auto- rejected
Auto-rejected because of new version 3 was uploaded