Review of "Baha" version 4

Details Page Preview

A lightweight extension that brings live gold, currency, coin, and cryptocurrency rates to your top bar, built with Persian-speaking users in mind. Supports both Persian and English with full customization.

Extension Homepage
https://github.com/the6fallenangel/gnome-baha

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from the import: - line 5 `indicator.js` - line 3 `extension.js` 2. Remove try-catch wrappers: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 3. Timeout should be removed before creating a new one (line 235 `indicator.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 4. Each class should be responsible for what is does. `_fetchAndUpdate()` (line 74 `extension.js`) should be inside `BahaIndicator` class. 5. Remove all the `png` files. Only SVG would be enough. 7. Why are you using hard coded language translation in `menuBuilder.js`? Shouldn't they come from `constants.js`? If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions