Review of "MagniMap" version 1.0 (1)

Details Page Preview

Magnifier with minimap, dead-zone pan, and extend-domain toggle, driving GNOME's built-in magnifier

Extension Homepage
https://github.com/Amir-Mehrpanah/magnimap-GNOME-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:120
            this._deadZoneLabel = new St.Label({
                style: 'color: #3399ff; font-weight: bold; background-color: rgba(0,0,0,0.6); padding: 2px 4px;',
                reactive: false,
            })
  • extension.js:111
            this._indicatorActor = new St.Widget({
                style: 'border: 2px solid #00ff00; background-color: transparent;',
                reactive: false,
            })

All Versions

Version Status
1.2 (3) Active
1.0 (2) Inactive
1.0 (1) Inactive

Previous Reviews on this Version

JustPerfection active
Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
amirmehrpanah posted a review
Thanks for the review — addressed two points: - Replaced the loop-based .destroy() calls in disable() with explicit calls for each actor (_indicatorActor, _deadZoneMainActor, _deadZoneMinimapActor, _deadZoneLabel), so cleanup is directly traceable per object. - Switched the three signal connections (cursor-changed, active-changed, changed::sensitivity) to connectObject()/disconnectObject() as suggested.