Review of "Twingate Panel" version 3

Details Page Preview

Control the Twingate VPN client (connect/disconnect, status, resources) from the GNOME top panel.

Extension Homepage
https://github.com/urhend/twingate-panel

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.0.6 (6) Active
1.0.4 (5) Rejected
1.0.4 (4) Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please fix `─` and `?.(`. 2. Extension cannot use `sudo` (line 271 `extension.js`): [EGO Review Guidelines: Privileged Subprocess](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#privileged-subprocess-must-not-be-user-writable) 3. I cannot trace back the value of `address` (line 114 `extension.js`). The value that is used in spawn command should be easily traceable. 4. `action` should be hardcoded since that is privileged subprocess (line 270 `extension.js`). 5. Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) and please follow our guidelines in [Extension Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions