Review of "WinClip" version 2

Details Page Preview

A Windows-style clipboard manager. Super+V opens an overlay at the pointer, over whatever window you are in. • Clipboard — text and image history, with pinned entries kept at the top • GIF — GIFs you have copied, favourites, and animated GIFs found in your Downloads and Pictures folders • Emoji — searchable by name and keyword, with pins, recents and a skin tone setting Choosing an entry pastes it straight into the window underneath. Requires Wayland.

Extension Homepage
https://github.com/stevebushwa/winclip

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • clipboardMonitor.js:29
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • imageUtil.js:63
    console.error('winclip: could not upload image to the GPU', e)
  • imageUtil.js:289
    console.error('winclip: gif playback failed', e)
  • imageUtil.js:57
                console.warn(`winclip: texture upload refused for ${width}x${height} ` +
                    `alpha=${pixbuf.get_has_alpha()} rowstride=${pixbuf.get_rowstride()}`)
  • imageUtil.js:95
    console.warn(`winclip: cannot read ${path}`, e)
  • imageUtil.js:120
    console.warn(`winclip: cannot animate ${path}`, e)
  • imageUtil.js:332
    console.warn(`winclip: cannot decode ${path}`, e)
  • store.js:60
    console.error('winclip: store listener failed', e)
  • store.js:84
    console.error('winclip: store.json unreadable, starting fresh', e)
  • store.js:182
    console.error('winclip: could not write store.json', e)
  • store.js:193
    console.error('winclip: could not write store.json', e)
  • store.js:225
    console.error('winclip: could not write blob', e)
  • store.js:124
                console.warn(`winclip: dropped ${doomed.length} image ` +
                    `entr${doomed.length === 1 ? 'y' : 'ies'} whose file was gone`)

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • gifSearch.js:73
    new GiphyProvider()

All Versions

Version Status
2 Unreviewed
1 Rejected