Review of "Menubar for Symfony" version 1.0 (1)

Details Page Preview

Manage local Symfony CLI servers from the top panel. Requires Symfony CLI (https://symfony.com/download) installed in PATH. * Start/stop servers * Open in browser * View logs * Manage PHP versions * Proxy status

Extension Homepage
https://github.com/tito10047/menubar-for-symfony

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:317
          this._browserBtn.connect("clicked", () => {
            this._onOpenBrowser(this._directory);
          })
  • extension.js:323
          this._favoriteBtn.connect("clicked", () => {
            this._onToggleFavorite(this._directory);
          })
  • extension.js:320
          this._logsBtn.connect("clicked", () => {
            this._onViewLogs(this._directory);
          })
  • extension.js:310
          this._startStopBtn.connect("clicked", () => {
            if (this._isRunning) {
              this._onStop(this._directory);
            } else {
              this._onStart(this._directory);
            }
          })
  • extension.js:264
    btn.connect("clicked", () => params.onCustomAction?.(action, this._directory))

All Versions

Version Status
1.2 (5) Unreviewed
1.2 (4) Rejected
1.2 (3) Rejected
1.1 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
Please don't transpile everything into one file, fix shexli issues and also use spaces between functions and classes. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions