Review "The Lyrics" version 1 - GNOME Shell Extensions

Review of "The Lyrics" version 1

Details Page Preview

The Lyrics

by dertefter

Displays lyrics in the top bar for playing music

Extension Homepage: https://github.com/dertefter/The-Lyrics

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

extension.js:31

        this._label = new St.Label({
            text: _('Nothing playing'),
            y_align: Clutter.ActorAlign.CENTER,
            style_class: 'lyrics-panel-label',
        })

All Versions

Version	Status
1	Unreviewed