Review of "Quake Anything" version 2

Details Page Preview

Drop down (or side-dock) any GUI app with a keyboard shortcut — Quake-style, not just a terminal. * Dock apps to top, bottom, left, or right * Each app has its own shortcut and size percentage * Only windows spawned by this extension are controlled * Configure everything in the extension Settings (no panel icon)

Extension Homepage
https://github.com/yccoskun/quake-anything

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1

Shexli found 1 issue that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • quake-manager.js:24
    legacy.unmaximize(Meta.MaximizeFlags.BOTH)

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). 2. Please use empty new lines between functions and classes. 3. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions