Review of "Quick TOTP" version 1.1.0 (2)

Details Page Preview

Quick TOTP is a fast and lightweight GNOME Shell extension for generating One-Time Passwords (OTP), with support for both TOTP and HOTP. Access your two-factor authentication (2FA) codes directly from the top panel for services like Google, GitHub, Discord, Amazon, Steam, Facebook, Microsoft, and thousands of other OTP-compatible websites and applications. The panel menu offers a scrollable list, instant search/filter, a show/hide toggle for codes, a live countdown for each entry, and full keyboard navigation. NOTE: This extension uses the clipboard: - clicking on an OTP entry in the indicator will copy the generated code to the clipboard; - the preferences window will copy a generated code to the clipboard when clicked on the corresponding button; - the preferences window will copy the OTP secret to the clipboard when selecting the "Copy to clipboard" menu option; - after copying an OTP secret into the clipboard the clipboard will be cleared after a configurable amount of time (default is 30 seconds); - when creating or editing an OTP secret, the paste button (on the top right) will paste the OTP secret (as text or QR image) from the clipboard.

Extension Homepage
https://github.com/brunos3d/gnome-shell-extension-quick-totp

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • prefs.js:94
    console.error(e)
  • prefs.js:103
    console.error(ee)
  • prefs.js:920
    console.error(e)
  • prefs.js:1058
    console.error(e)
  • prefs.js:1101
    console.error(e)
  • prefs.js:1154
    console.error(e)
  • prefs.js:1175
    console.error(e)
  • prefs.js:1187
    console.error(e)
  • prefs.js:1258
    console.error(e)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • src/shell/indicator.js:30
    St.Clipboard.get_default()

All Versions

Version Status
1.1.2 (4) Active
1.1.1 (3) Rejected
1.1.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

brunos3d auto- rejected
Auto-rejected because of new version 1.1.1 (3) was uploaded