Review of "Hyper Credits" version 5

Details Page Preview

Shows your remaining Charm Hyper credits in the top bar

Extension Homepage
https://github.com/arnarg/gnome-extension-hyper-credits

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • indicator.js:445
    St.Clipboard.get_default()

All Versions

Version Status
9 Active
8 Rejected
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 2. Timeout should be removed before creating a new one: - line 286 `hyperClient.js` - line 181 `indicator.js` [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 3. `this._destroyed`, `_onDestroy()` are bad practices. Please fix them: [Extension Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html) Please avoid sending large diff. It can wait even more than a month since the review queue is very busy. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions