Review of "chesscom-notifier" version 2

Details Page Preview

Check chess.com for daily game moves and unread messages. This extension is not affiliated, funded, or in any way associated with chess.com.

Extension Homepage
https://github.com/sabetts/chesscom-notifier-gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection active
1. Not needed really (line 99 `prefs.js`). 2. Please add this to the description: > This extension is not affiliated, funded, or in any way associated with chess.com.
sabetts posted a review
1. I just tested without the apply upon window close and without it the settings don't get saved. this is, I *think*, because of settings.delay() on line 37. The problem I'm trying to solve is that without this delay() call every update to the username while in the prefs panel kicks off an http request to the API, which is excessive. So the idea is to delay updating the settings until the window is closed, leading to just one API call. Perhaps there's a better way to do what I'm trying to do? 2. I'll add this in the next upload!
sabetts posted a review
I've thought about #1 some more and I think I've got an improvement that will work better. I'll upload a new version when I've got it working.
JustPerfection posted a review
You mean line 50 `prefs.js` cannot catch the text change and save it immediately to the settings?