Review of "MAC Address Converter" version 3

Details Page Preview

Quickly convert and copy MAC address formats (colons, hyphens, dots, clean hex) to clipboard directly from the GNOME panel. This extension accesses the clipboard.

Extension Homepage
https://github.com/loginone33/gnome-shell-extension-mac-converter

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:71
    St.Clipboard.get_default()
  • extension.js:208
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:154
    this._copyBtn.connect('clicked', () => this._copyResult())
  • extension.js:55
            this._entry.clutter_text.connect('activate', () => {
                this._convert(':');
            })
  • extension.js:59
            this._entry.clutter_text.connect('text-changed', () => {
                this._updateResult('');
            })

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
loginone posted a review
Thank You!