Review of "Chand" version 2

Details Page Preview

Live cryptocurrency, fiat currency, and gold prices in Iranian Toman/Rial

Extension Homepage
https://github.com/khodekia/chand

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the version from the import (line 7 `api.js`). 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. You should call `abort()` on disable or destroy (line 21 `api.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 4. Better to remove the timeout before creating a new one (line 110 `extension.js`). 5. Please follow [Extension Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions