Review of "Active App Tabs" version 1

Details Page Preview

Active App Tabs streamlines your desktop workflow through persistent window ordering, dynamic geometry, and instant focus tracking. It brings structured tabbed window management directly into your GNOME Shell workspace. ⚠️IMPORTANT⚠️ Right Clock and Notification extension must be installed for this extension to work properly.

Extension Homepage
https://github.com/DhmDevops/Active-App-Tabs

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • src/AppTab.js:384
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:34
            this._invisibleSpacer = new St.Widget({
                x_expand: true,
                y_expand: true
            })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:34
            this._invisibleSpacer = new St.Widget({
                x_expand: true,
                y_expand: true
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:84
            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._updateJailbreakGeometry();
                this._syncVisibility();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
8 Unreviewed
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

hembram auto- rejected
Auto-rejected because of new version 2 was uploaded