Review of "NTS Live Player" version 2

Details Page Preview

Stream NTS Radio 1, Radio 2 and Infinite Mixtapes directly from the Quick Settings panel.

Extension Homepage
https://git.sr.ht/~arnakazim/gnome-nts-player

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • cache.js:21
    GLib.file_get_contents(CACHE_FILE)
  • cache.js:66
    GLib.file_get_contents(LOGO_FILE)

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:56
        disable() {
            if (this._initTimeoutId) {
                GLib.source_remove(this._initTimeoutId);
                this._initTimeoutId = null;
            }
    
            if (this._indicator) {
                this._indicator.setHeavyInitCallback(null);
                this._indicator.destroy();
                this._i

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

arnakazim posted a review
This version is fully functioning and integrates correctly in GNOME