Review of "OMP Send Context" version 1

Details Page Preview

Send focused Ptyxis PRIMARY clipboard selections to OMP

Extension Homepage
https://github.com/klondikemarlen/omp-send-context

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:88
    Gio.File.new_for_path(path).load_contents(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:43
    St.Clipboard.get_default()

All Versions

Version Status
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove the version from the import (line 5 `extension.js`). 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. Please follow our [best practices](https://gjs.guide/extensions/review-guidelines/best-practices.html). Especially for unnecessary `?.(`. and also please note, we have a rule for AI: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) 4. Please add to the description that this extension is using clipboard: [EGO Review Guidelines: Clipboard](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#clipboard-access-must-be-declared) 5. Please use aysnc for reading file content since you are in shell process (line 88 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 6. You should call `abort()` on disable (line 65 `extension.js`): [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions