Review of "Economic Calender" version 1.1 (1)

Details Page Preview

Top-panel economic calendar of upcoming macro events (FOMC, CPI, NFP, and more) with impact filtering, day grouping, and forecast/previous values. Network access: this extension downloads a public weekly economic calendar feed to show scheduled events. Responses may be cached on disk under your user cache directory. No account is required.

Extension Homepage
https://github.com/N0L0g1c/Economic-Calender

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:161
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:391
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (!open || this._fetching)
                    return;
                // Only refresh from network when opening if data is stale
                const age = Date.now() - this._lastSuccessAt;
                if (!this._events.length ||

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:377
            this._session = new Soup.Session({
                timeout: 20,
                user_agent: USER_AGENT,
            })

All Versions

Version Status
1.1 (2) Unreviewed
1.1 (1) Rejected

Previous Reviews on this Version

NoLo auto- rejected
Auto-rejected because of new version 1.1 (2) was uploaded