EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• extension.js:108

  file.load_contents(null)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• extension.js:323

          this._entry = new St.Entry({
              style_class: 'financial-macros-symbol-entry',
              hint_text: 'Symbol',
              can_focus: true,
              x_expand: true,
          })

• extension.js:333

          this._errorLabel = new St.Label({
              text: '',
              style_class: 'financial-macros-dialog-error',
              visible: false,
          })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• extension.js:323

          this._entry = new St.Entry({
              style_class: 'financial-macros-symbol-entry',
              hint_text: 'Symbol',
              can_focus: true,
              x_expand: true,
          })

• extension.js:333

          this._errorLabel = new St.Label({
              text: '',
              style_class: 'financial-macros-dialog-error',
              visible: false,
          })

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:331

  this._entry.clutter_text.connect('activate', () => this._submit())

• extension.js:560

          dialog.connect('closed', () => {
              if (this._addDialog === dialog)
                  this._addDialog = null;
          })

• extension.js:481

          this.menu.connect('open-state-changed', (_menu, open) => {
              if (open && !this._fetching)
                  this._fetchAll().catch(e => logError(e));
              if (!open && this._favoritesSub)
                  this._favoritesSub.setSubmenuShown(false);
          })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

• extension.js:472

          this._session = new Soup.Session({
              timeout: 15,
              user_agent: 'financial-macros@n0l0g1c.github.io/1.1',
          })