Review of "GNOME Shell Cast" version 2

Details Page Preview

Cast your whole screen or a single window to a Chromecast device from the top panel, with system audio. Audio-only receivers (speakers, cast groups) are detected and offered as an audio share. Copies to the clipboard only when you press "Copy command" or "Copy details" in its dialogs. Requires the gnome-shell-cast-daemon to be installed (see the project README). Keywords: chromecast / cast / google cast / screencast / screen mirroring / screen sharing / wireless display / tv / nest hub / speakers Please β€œrate” πŸ’“ the project here and give it a 🌟 on GitHub. If you encounter any issues or have suggestions, feel free to open an issue on GitHub!

Extension Homepage
https://github.com/omid/gnome-shell-cast

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/errorDialog.js:46
    St.Clipboard.get_default()
  • lib/setupDialog.js:53
    St.Clipboard.get_default()

All Versions

Version Status
3 Active
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection active
Thanks!
JustPerfection posted a review
BTW, you still have broken characters in line 20 `lib/setupDialog.js`.
omid posted a review
Thanks. It is "(installed v%old β†’ needs v%new)". I don't know what it shows like that here. Should I encode it to something else? It's a unicode char.
JustPerfection posted a review
Delete that line and type it out (don't copy and paste).
JustPerfection posted a review
BTW, since you're using AI, just in case you missed this one: https://gjs.guide/extensions/review-guidelines/best-practices.html
omid posted a review
It's the right arrow key, I cannot type it here: β†’ :( ps: Thanks for the link, I'll ask my artificial slave to follow it :D
omid posted a review
I meant right arrow character
JustPerfection posted a review
That's what I meant, you cannot paste that "Unicode character". Instead, you can type ->
omid posted a review
So you mean I shouldn't use unicode characters in gnome-shell/js/gjs?
JustPerfection posted a review
I didn't try this extension on a live but if that's working on your setup, don't need to change it. The review page here cannot show Unicode characters.
omid posted a review
Thanks <3