Review of "CSIRT Alertas" version 4

Details Page Preview

Muestra las últimas alertas de ciberseguridad del CSIRT de Chile (csirt.gob.cl) en la barra superior de GNOME y notifica cuando aparecen alertas nuevas. Aplicación Creada Por Anibal Segovia Poblete

Extension Homepage
https://github.com/critercl/csirt-alertas

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:370
    file.load_contents(null)
  • extension.js:577
    file.load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:526
    this._notifSource.connect('destroy', () => (this._notifSource = null))
  • extension.js:546
    notification.connect('activated', () => this._openUri(primary.link))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Version Status
8 Unreviewed
7 Unreviewed
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please read version 1 review.