Review of "Local Share" version 3

Details Page Preview

Transfer files between devices on your local network through a web browser

Extension Homepage
https://github.com/RightFix/LocalShare

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • src/main.js:621
    approveItem.connect('activate', () => this._approveClient(client.id))
  • src/main.js:228
    recvItem.connect('activate', () => this._onReceive())
  • src/main.js:625
    rejectItem.connect('activate', () => this._rejectClient(client.id))
  • src/main.js:224
    sendItem.connect('activate', () => this._onSend())
  • src/main.js:206
    stopItem.connect('activate', () => this._onStopSending())
  • src/main.js:215
    stopItem.connect('activate', () => this._onStop())

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected