Review of "Serenity Desktop" version 11

Details Page Preview

A Per-Monitor-Workspace window manager designed for productive use. It offers two main features: - Per-monitor workspaces: Compatible with both static and dynamic workspaces. - Application/Window shortcuts: Assign shortcuts to windows and bring the workspace containing the window into view, regardless of its location. Shortcuts are assigned using Super-Shift-Number and can be referred to with Super-Number. Note that this may conflict with default shortcuts, which must be resolved after installation. Visit the homepage for usage details, backports, and additional post-installation instructions.

Extension Homepage
https://gitlab.com/sisujs/serenity-desktop/-/blob/main/README.md

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:149
    this.nativeEvents.connect(global.workspace_manager, "active-workspace-changed", (() => this.workspaceChanged()))
  • extension.js:150
    this.nativeEvents.connect(global.workspace_manager, "notify::n-workspaces", (() => this.workspaceCountChanged()))
  • extension.js:151
    this.nativeEvents.connect(global.display, "notify::n-monitors", (() => this.initWorkspaces()))
  • extension.js:152
    this.nativeEvents.connect(Main.layoutManager, "monitors-changed", (() => this.initWorkspaces()))
  • extension.js:450
        this.shortcuts[index].button.connect("clicked", (() => {
          this.db.shortcuts.removeByIndex(index);
        }))
  • extension.js:540
    this.nativeEvents.connect(global.display, "window-created", ((_display, window) => this.onWindowCreate(window)))
  • extension.js:541
    this.nativeEvents.connect(global.window_manager, "destroy", ((_shellwm, actor) => this.onWindowDestroy(actor.meta_window)))
  • extension.js:552
    this.nativeEvents.connect(mw, "notify::title", (() => this.events.notifyTitleChanged(mw.get_id())))

All Versions

Version Status
13 Active
12 Active
11 Rejected
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please remove `schemas/gschemas.compiled` and send it again.